friendica.git/.git
3 years agoFix message "empty network" in gcontact::getid
Michael [Fri, 10 Jul 2020 19:49:11 +0000 (19:49 +0000)]
Fix message "empty network" in gcontact::getid

3 years agoMerge pull request #8858 from annando/issue-8857
Hypolite Petovan [Fri, 10 Jul 2020 12:02:20 +0000 (08:02 -0400)]
Merge pull request #8858 from annando/issue-8857

Issue 8857: Fix follow accept answers

3 years agoMerge pull request #8859 from annando/fix-callstack
Hypolite Petovan [Fri, 10 Jul 2020 12:01:06 +0000 (08:01 -0400)]
Merge pull request #8859 from annando/fix-callstack

Fix unneeded database functions in the callstack

3 years agoFix unneeded database functions in the callstack
Michael [Fri, 10 Jul 2020 07:01:28 +0000 (07:01 +0000)]
Fix unneeded database functions in the callstack

3 years agoIssue 8857: Fix follow accept answers
Michael [Fri, 10 Jul 2020 05:30:12 +0000 (05:30 +0000)]
Issue 8857: Fix follow accept answers

3 years agoMerge pull request #8856 from annando/db-speed
Hypolite Petovan [Thu, 9 Jul 2020 22:48:15 +0000 (18:48 -0400)]
Merge pull request #8856 from annando/db-speed

Fix speed issues with the network page

3 years agoFix speed issues with the network page
Michael Vogel [Thu, 9 Jul 2020 22:22:26 +0000 (00:22 +0200)]
Fix speed issues with the network page

3 years agoMerge pull request #8854 from MrPetovan/bug/notices
Michael Vogel [Thu, 9 Jul 2020 19:45:27 +0000 (21:45 +0200)]
Merge pull request #8854 from MrPetovan/bug/notices

Address various notices again

3 years agoMerge pull request #8855 from annando/diaspora-plink
Hypolite Petovan [Thu, 9 Jul 2020 19:32:50 +0000 (15:32 -0400)]
Merge pull request #8855 from annando/diaspora-plink

Fix the plink for reshared Diaspora posts

3 years agoFix the plink for reshared Diaspora posts
Michael [Thu, 9 Jul 2020 19:19:18 +0000 (19:19 +0000)]
Fix the plink for reshared Diaspora posts

3 years agoAdd checks for $a->user existence
Hypolite Petovan [Thu, 9 Jul 2020 19:08:09 +0000 (15:08 -0400)]
Add checks for $a->user existence

- Variable can be empty/null in many cases

3 years agoAdd check for $a->profile structure in Module\HoverCard
Hypolite Petovan [Thu, 9 Jul 2020 19:06:50 +0000 (15:06 -0400)]
Add check for $a->profile structure in Module\HoverCard

3 years agoAdd check for parent item existence in Model\UserItem::setNotificationForUser
Hypolite Petovan [Thu, 9 Jul 2020 19:05:11 +0000 (15:05 -0400)]
Add check for parent item existence in Model\UserItem::setNotificationForUser

3 years agoAdd missing $a->profile initialization in mod/cal
Hypolite Petovan [Thu, 9 Jul 2020 19:04:30 +0000 (15:04 -0400)]
Add missing $a->profile initialization in mod/cal

3 years agoMove logged in logging where it makes sense in include/api
Hypolite Petovan [Thu, 9 Jul 2020 19:03:48 +0000 (15:03 -0400)]
Move logged in logging where it makes sense in include/api

3 years agoAdd check for exif data existence in mod/photos
Hypolite Petovan [Thu, 9 Jul 2020 19:03:14 +0000 (15:03 -0400)]
Add check for exif data existence in mod/photos

3 years agoMerge pull request #8853 from annando/issue-8836
Hypolite Petovan [Wed, 8 Jul 2020 22:41:41 +0000 (18:41 -0400)]
Merge pull request #8853 from annando/issue-8836

Issue 8836: Point the event to the local post

3 years agoMerge pull request #8852 from MrPetovan/bug/notices
Michael Vogel [Wed, 8 Jul 2020 20:51:13 +0000 (22:51 +0200)]
Merge pull request #8852 from MrPetovan/bug/notices

Address various notices

3 years agoUse the "orig_title"
Michael [Wed, 8 Jul 2020 20:47:05 +0000 (20:47 +0000)]
Use the "orig_title"

3 years agoIssue 8836: Point the event to the local post
Michael [Wed, 8 Jul 2020 20:42:28 +0000 (20:42 +0000)]
Issue 8836: Point the event to the local post

3 years agoAdd logging to unexpected case in Content\Nav
Hypolite Petovan [Wed, 8 Jul 2020 13:56:40 +0000 (09:56 -0400)]
Add logging to unexpected case in Content\Nav

- Address part of https://github.com/friendica/friendica/issues/8475#issuecomment-653912096

3 years agoAdd error handling in Module\Profile\Status
Hypolite Petovan [Wed, 8 Jul 2020 13:49:39 +0000 (09:49 -0400)]
Add error handling in Module\Profile\Status

- Address part of https://github.com/friendica/friendica/issues/8475#issuecomment-653912096

3 years agoAdd error handling in Module\Xrd
Hypolite Petovan [Wed, 8 Jul 2020 13:14:34 +0000 (09:14 -0400)]
Add error handling in Module\Xrd

- Address part of https://github.com/friendica/friendica/issues/8475#issuecomment-653912096

3 years agoMerge pull request #8851 from annando/issue-8844
Hypolite Petovan [Tue, 7 Jul 2020 12:56:10 +0000 (08:56 -0400)]
Merge pull request #8851 from annando/issue-8844

Issue 8844: Fix probing of unknown AP contacts

3 years agoMerge pull request #8849 from MrPetovan/task/8846-console-user-tweaks
Michael Vogel [Tue, 7 Jul 2020 05:02:05 +0000 (07:02 +0200)]
Merge pull request #8849 from MrPetovan/task/8846-console-user-tweaks

Rename -q option to -y for user delete console command

3 years agoIssue 8844: Fiy probing of unknown AP contacts
Michael [Tue, 7 Jul 2020 04:47:15 +0000 (04:47 +0000)]
Issue 8844: Fiy probing of unknown AP contacts

3 years agoMerge pull request #8850 from annando/fix-follow
Hypolite Petovan [Mon, 6 Jul 2020 20:07:52 +0000 (16:07 -0400)]
Merge pull request #8850 from annando/fix-follow

Issue 8844: Rework "follow" to fix probing issues

3 years agoRework "follow" to fix probing issues
Michael [Mon, 6 Jul 2020 19:49:29 +0000 (19:49 +0000)]
Rework "follow" to fix probing issues

3 years agoExclude deleted user accounts from "active" user list in Model\User
Hypolite Petovan [Mon, 6 Jul 2020 19:26:39 +0000 (15:26 -0400)]
Exclude deleted user accounts from "active" user list in Model\User

3 years agoRename -q option to -y for user delete console command
Hypolite Petovan [Mon, 6 Jul 2020 19:25:49 +0000 (15:25 -0400)]
Rename -q option to -y for user delete console command

- Name was misleading, it isn't quiet mode but non-interactive mode

3 years agoMerge pull request #8841 from MrPetovan/task/8839-httpsignature-hs2019
Michael Vogel [Mon, 6 Jul 2020 05:09:27 +0000 (07:09 +0200)]
Merge pull request #8841 from MrPetovan/task/8839-httpsignature-hs2019

Add support for "hs2019" algorithm value in Util\HTTPSignature

3 years agoMerge pull request #8842 from MrPetovan/bug/warnings
Tobias Diekershoff [Sun, 5 Jul 2020 07:33:04 +0000 (09:33 +0200)]
Merge pull request #8842 from MrPetovan/bug/warnings

Bug/warnings

3 years agoEnsure $contact_record is an array in mod/item
Hypolite Petovan [Sat, 4 Jul 2020 19:33:54 +0000 (15:33 -0400)]
Ensure $contact_record is an array in mod/item

3 years agoAccount for falsy values for $forum_contact in mod/item
Hypolite Petovan [Sat, 4 Jul 2020 19:33:35 +0000 (15:33 -0400)]
Account for falsy values for $forum_contact in mod/item

- Rare condition can make it false
- Simplify notification sending condition

3 years agoAdd support for "hs2019" algorithm value in Util\HTTPSignature
Hypolite Petovan [Sat, 4 Jul 2020 17:12:59 +0000 (13:12 -0400)]
Add support for "hs2019" algorithm value in Util\HTTPSignature

3 years agoMerge pull request #8837 from MrPetovan/bug/8829-add-expected-sort-string-support
Tobias Diekershoff [Thu, 2 Jul 2020 04:59:25 +0000 (06:59 +0200)]
Merge pull request #8837 from MrPetovan/bug/8829-add-expected-sort-string-support

Add expected support for sort strings in select() parameters

3 years agoAdd expected support for sort strings in select() parameters
Hypolite Petovan [Thu, 2 Jul 2020 02:54:14 +0000 (22:54 -0400)]
Add expected support for sort strings in select() parameters

- Fix unexpected behaviors with calls already using the sort strings

3 years agoMerge pull request #8835 from tobiasd/20200701-lng
Hypolite Petovan [Wed, 1 Jul 2020 11:08:04 +0000 (07:08 -0400)]
Merge pull request #8835 from tobiasd/20200701-lng

PL and EN US / GB translation updates

3 years agoEN US and GB translation updates THX AndyH3
Tobias Diekershoff [Wed, 1 Jul 2020 10:47:44 +0000 (12:47 +0200)]
EN US and GB translation updates THX AndyH3

3 years agoPL translation update THX Walis
Tobias Diekershoff [Wed, 1 Jul 2020 10:45:43 +0000 (12:45 +0200)]
PL translation update THX Walis

3 years agoMerge pull request #8834 from MrPetovan/task/introduce-stable-branch
Michael Vogel [Tue, 30 Jun 2020 21:23:00 +0000 (23:23 +0200)]
Merge pull request #8834 from MrPetovan/task/introduce-stable-branch

Introduce stable branch

3 years agoUpdate references to the friendica/friendica-directory stable branch
Hypolite Petovan [Mon, 15 Jun 2020 17:48:18 +0000 (13:48 -0400)]
Update references to the friendica/friendica-directory stable branch

3 years agoUpdate references to the friendica/friendica-addons stable branch
Hypolite Petovan [Mon, 15 Jun 2020 17:48:08 +0000 (13:48 -0400)]
Update references to the friendica/friendica-addons stable branch

3 years agoUpdate references to the friendica/friendica stable branch
Hypolite Petovan [Mon, 15 Jun 2020 17:47:23 +0000 (13:47 -0400)]
Update references to the friendica/friendica stable branch

3 years agoMerge pull request #8832 from annando/fix-db-error
Hypolite Petovan [Tue, 30 Jun 2020 18:55:52 +0000 (14:55 -0400)]
Merge pull request #8832 from annando/fix-db-error

Fix database error ""Unknown column 'parent-item.author-id'"

3 years agoChanged structure
Michael [Tue, 30 Jun 2020 17:51:03 +0000 (17:51 +0000)]
Changed structure

3 years agoMerge pull request #8826 from annando/fix-logging
Hypolite Petovan [Tue, 30 Jun 2020 13:05:01 +0000 (09:05 -0400)]
Merge pull request #8826 from annando/fix-logging

Replace deprecated Logger calls

3 years agoMerge pull request #8831 from MrPetovan/bug/fatal-errors
Michael Vogel [Tue, 30 Jun 2020 05:57:23 +0000 (07:57 +0200)]
Merge pull request #8831 from MrPetovan/bug/fatal-errors

Account for false return value of Repository\Notify->insert in notification()

3 years agoFix database error ""Unknown column 'parent-item.author-id'"
Michael [Tue, 30 Jun 2020 05:49:22 +0000 (05:49 +0000)]
Fix database error ""Unknown column 'parent-item.author-id'"

3 years agoAccount for false return value of Repository\Notify->insert in notification()
Hypolite Petovan [Mon, 29 Jun 2020 22:58:17 +0000 (18:58 -0400)]
Account for false return value of Repository\Notify->insert in notification()

- Address https://github.com/friendica/friendica/issues/8473#issuecomment-651393541

3 years ago"print_r" in logging replaced / obsolete stuff removed
Michael [Mon, 29 Jun 2020 20:22:00 +0000 (20:22 +0000)]
"print_r" in logging replaced / obsolete stuff removed

3 years agoNext logger calls replaced
Michael [Sun, 28 Jun 2020 18:22:29 +0000 (18:22 +0000)]
Next logger calls replaced

3 years agoFurther deprecated calls replaced
Michael [Sun, 28 Jun 2020 17:50:11 +0000 (17:50 +0000)]
Further deprecated calls replaced

3 years agoSome more replaced logger
Michael [Sun, 28 Jun 2020 17:35:56 +0000 (17:35 +0000)]
Some more replaced logger

3 years agoReplace deprecated Logger calls
Michael [Sun, 28 Jun 2020 15:43:58 +0000 (15:43 +0000)]
Replace deprecated Logger calls

3 years agoMerge pull request #8825 from annando/render-speed
Tobias Diekershoff [Sun, 28 Jun 2020 14:18:36 +0000 (16:18 +0200)]
Merge pull request #8825 from annando/render-speed

Improve render speed by not probing for unknown contacts

3 years agoImprove render speed by not probing for unknown contacts
Michael Vogel [Sun, 28 Jun 2020 13:57:33 +0000 (15:57 +0200)]
Improve render speed by not probing for unknown contacts

3 years agoMerge pull request #8821 from MrPetovan/bug/fix-item-source-route
Michael Vogel [Sun, 28 Jun 2020 12:02:25 +0000 (14:02 +0200)]
Merge pull request #8821 from MrPetovan/bug/fix-item-source-route

Improve Module\Admin\Item\Source

3 years agoImprove Module\Admin\Item\Source
Hypolite Petovan [Sun, 30 Jun 2019 17:33:33 +0000 (13:33 -0400)]
Improve Module\Admin\Item\Source

- Use router parameter
- Accept full URLs with GUID in form
- Fix 500 error when item with guid doesn't exist

3 years agoMerge pull request #8823 from annando/keyword-notices
Tobias Diekershoff [Sun, 28 Jun 2020 09:10:37 +0000 (11:10 +0200)]
Merge pull request #8823 from annando/keyword-notices

Fix notice "Undefined index: keywords"

3 years agoMerge pull request #8824 from annando/fix-coord
Tobias Diekershoff [Sun, 28 Jun 2020 09:08:22 +0000 (11:08 +0200)]
Merge pull request #8824 from annando/fix-coord

Fix processing of received coordinates

3 years agoFix processing of received coordinates
Michael [Sun, 28 Jun 2020 08:46:27 +0000 (08:46 +0000)]
Fix processing of received coordinates

3 years agoMerge pull request #8822 from MrPetovan/bug/8709-frio-admin-site-accordion
Michael Vogel [Sun, 28 Jun 2020 06:25:22 +0000 (08:25 +0200)]
Merge pull request #8822 from MrPetovan/bug/8709-frio-admin-site-accordion

[frio] Add missing margin above relocate form in admin site

3 years agoEmpty lines removed
Michael Vogel [Sun, 28 Jun 2020 06:23:53 +0000 (08:23 +0200)]
Empty lines removed

3 years agoFix notice "Undefined index: keywords"
Michael Vogel [Sun, 28 Jun 2020 06:18:35 +0000 (08:18 +0200)]
Fix notice "Undefined index: keywords"

3 years ago[frio] Add missing margin above relocate form in admin site
Hypolite Petovan [Sat, 27 Jun 2020 22:37:02 +0000 (18:37 -0400)]
[frio] Add missing margin above relocate form in admin site

3 years agoMerge pull request #8811 from MrPetovan/task/8517-probe-mobile-twitter
Michael Vogel [Sat, 27 Jun 2020 15:32:19 +0000 (17:32 +0200)]
Merge pull request #8811 from MrPetovan/task/8517-probe-mobile-twitter

Add support for mobile profile URL to core twitter probing

3 years agoMerge pull request #8820 from annando/fix-author-network
Hypolite Petovan [Sat, 27 Jun 2020 15:28:14 +0000 (11:28 -0400)]
Merge pull request #8820 from annando/fix-author-network

Fix notice "Undefined index: author-network"

3 years agoFix notice "Undefined index: author-network"
Michael [Sat, 27 Jun 2020 15:10:06 +0000 (15:10 +0000)]
Fix notice "Undefined index: author-network"

3 years agoSimplify sender handle assignment in Model\Mail
Hypolite Petovan [Sat, 27 Jun 2020 13:34:19 +0000 (09:34 -0400)]
Simplify sender handle assignment in Model\Mail

3 years agoMerge pull request #8817 from annando/ap-diaspora-delivery
Hypolite Petovan [Sat, 27 Jun 2020 13:30:11 +0000 (09:30 -0400)]
Merge pull request #8817 from annando/ap-diaspora-delivery

Prevent delivering AP comments to Diaspora

3 years agoMerge pull request #8816 from annando/fix-ap-receiving
Tobias Diekershoff [Sat, 27 Jun 2020 12:52:02 +0000 (14:52 +0200)]
Merge pull request #8816 from annando/fix-ap-receiving

Fix receiving non public posts from AP

3 years agoPrevent delivering AP comments to Diaspora
Michael [Sat, 27 Jun 2020 12:18:36 +0000 (12:18 +0000)]
Prevent delivering AP comments to Diaspora

3 years agoFix receiving non public posts from AP
Michael [Sat, 27 Jun 2020 10:35:45 +0000 (10:35 +0000)]
Fix receiving non public posts from AP

3 years agoAdd support for mobile profile URL to core twitter probing
Hypolite Petovan [Thu, 25 Jun 2020 01:07:49 +0000 (21:07 -0400)]
Add support for mobile profile URL to core twitter probing

3 years agoEnsure url property of Probe::uri result is used authoritatively
Hypolite Petovan [Thu, 25 Jun 2020 00:57:47 +0000 (20:57 -0400)]
Ensure url property of Probe::uri result is used authoritatively

- Some profile URLs aren't canonical and need to be updated during probe

3 years agoMerge pull request #8815 from annando/forum-notice
Hypolite Petovan [Fri, 26 Jun 2020 12:13:12 +0000 (08:13 -0400)]
Merge pull request #8815 from annando/forum-notice

Fix for "PHP Notice:  Undefined index: forum in /src/Protocol/OStatus.php on line 2091"

3 years agoFix notice "Undefined index: forum"
Michael [Fri, 26 Jun 2020 05:29:00 +0000 (05:29 +0000)]
Fix notice "Undefined index: forum"

3 years agoNew function to fetch contact data by url
Michael [Fri, 26 Jun 2020 05:28:25 +0000 (05:28 +0000)]
New function to fetch contact data by url

3 years agoMerge pull request #8813 from annando/issue-8807
Hypolite Petovan [Thu, 25 Jun 2020 21:04:50 +0000 (17:04 -0400)]
Merge pull request #8813 from annando/issue-8807

Issue 8807: Improved feed detecting

3 years agoUnify code structure
Michael [Thu, 25 Jun 2020 20:41:34 +0000 (20:41 +0000)]
Unify code structure

3 years agoIssue 8807: Improved feed detecting
Michael [Thu, 25 Jun 2020 20:29:21 +0000 (20:29 +0000)]
Issue 8807: Improved feed detecting

3 years agoMerge pull request #8803 from MrPetovan/bug/8477-api-photo-item-selectfirstforuser
Michael Vogel [Thu, 25 Jun 2020 17:22:49 +0000 (19:22 +0200)]
Merge pull request #8803 from MrPetovan/bug/8477-api-photo-item-selectfirstforuser

[API] Replace unwarranted Item::selectFirstForUser calls in photo endpoints

3 years agoReplace array_unique with GROUP BY clause in api_fr_photoalbum_delete()
Hypolite Petovan [Thu, 25 Jun 2020 12:05:09 +0000 (08:05 -0400)]
Replace array_unique with GROUP BY clause in api_fr_photoalbum_delete()

3 years agoMerge pull request #8805 from MrPetovan/bug/notices
Michael Vogel [Thu, 25 Jun 2020 06:39:28 +0000 (08:39 +0200)]
Merge pull request #8805 from MrPetovan/bug/notices

Add logging to rare condition in Model\Profile::sidebar

3 years agoMerge pull request #8804 from MrPetovan/bug/warnings
Michael Vogel [Thu, 25 Jun 2020 06:37:41 +0000 (08:37 +0200)]
Merge pull request #8804 from MrPetovan/bug/warnings

Add type hint to Database::insert

3 years agoMerge pull request #8809 from MrPetovan/bug/8808-db-error-contact
Michael Vogel [Thu, 25 Jun 2020 03:48:03 +0000 (05:48 +0200)]
Merge pull request #8809 from MrPetovan/bug/8808-db-error-contact

Add expected whitespace before Widget::unavailableNetworks() output

3 years agoAdd expected whitespace before Widget::unavailableNetworks() output in Module\Contact
Hypolite Petovan [Wed, 24 Jun 2020 22:49:55 +0000 (18:49 -0400)]
Add expected whitespace before Widget::unavailableNetworks() output in Module\Contact

3 years agoAdd logging to rare condition in Model\Profile::sidebar
Hypolite Petovan [Wed, 24 Jun 2020 13:56:11 +0000 (09:56 -0400)]
Add logging to rare condition in Model\Profile::sidebar

- Adresses https://github.com/friendica/friendica/issues/8475#issuecomment-647104375

3 years agoAdd type hint to Database::insert
Hypolite Petovan [Wed, 24 Jun 2020 13:36:34 +0000 (09:36 -0400)]
Add type hint to Database::insert

- Will escalate warning to fatal error in https://github.com/friendica/friendica/issues/8474#issuecomment-646802016

3 years ago[API] Replace unwarranted Item::selectFirstForUser calls in photo endpoints
Hypolite Petovan [Wed, 24 Jun 2020 12:14:45 +0000 (08:14 -0400)]
[API] Replace unwarranted Item::selectFirstForUser calls in photo endpoints

- Item::selectFirstForUser checks for item.visible = 1 which isn't necessarily set on photo-related items

3 years ago[API] Miscellaneous improvements
Hypolite Petovan [Wed, 24 Jun 2020 12:11:47 +0000 (08:11 -0400)]
[API] Miscellaneous improvements

- Use empty() instead of isset($r) && $r in save_media_to_database()
- Use expected variable name for result array in api_fr_photo_delete()
- Use correct associative array references in prepare_photo_data()
- Replace a() call in api_fr_photoalbum_delete()

3 years agoMerge pull request #8792 from MrPetovan/task/share-block-guid
Michael Vogel [Tue, 23 Jun 2020 19:26:07 +0000 (21:26 +0200)]
Merge pull request #8792 from MrPetovan/task/share-block-guid

[frio] Add local post link to share block when guid attribute is present

3 years agoMerge pull request #8802 from MrPetovan/task/8314-api-capture-login
Michael Vogel [Tue, 23 Jun 2020 19:23:08 +0000 (21:23 +0200)]
Merge pull request #8802 from MrPetovan/task/8314-api-capture-login

Update user.login_date for authenticated API calls

3 years agoMerge pull request #8801 from MrPetovan/task/8800-pre-whitespaces
Tobias Diekershoff [Tue, 23 Jun 2020 15:01:44 +0000 (17:01 +0200)]
Merge pull request #8801 from MrPetovan/task/8800-pre-whitespaces

[pre] blocks now preserve spaces

3 years agoAdd API login capture 12h cooldown to spare database writes
Hypolite Petovan [Tue, 23 Jun 2020 14:15:39 +0000 (10:15 -0400)]
Add API login capture 12h cooldown to spare database writes

3 years agoUpdate user.login_date for authenticated API calls
Hypolite Petovan [Tue, 23 Jun 2020 13:09:23 +0000 (09:09 -0400)]
Update user.login_date for authenticated API calls

3 years ago[pre] blocks now preserve spaces
Hypolite Petovan [Tue, 23 Jun 2020 11:53:18 +0000 (07:53 -0400)]
[pre] blocks now preserve spaces

- Added test case
- Added English documentation

3 years agoKeep spaces after non-tags in Content\BBCode::convert
Hypolite Petovan [Tue, 23 Jun 2020 11:52:38 +0000 (07:52 -0400)]
Keep spaces after non-tags in Content\BBCode::convert

- Added test case

3 years agoMerge pull request #8799 from MrPetovan/bug/3084-text-complete-catch-escape
Tobias Diekershoff [Tue, 23 Jun 2020 04:55:54 +0000 (06:55 +0200)]
Merge pull request #8799 from MrPetovan/bug/3084-text-complete-catch-escape

Prevent propagation of escape key press when it was used to close autocomplete dropdown