Return early if link is missing from share block in Model\Item
authorHypolite Petovan <hypolite@mrpetovan.com>
Sat, 7 Mar 2020 01:49:43 +0000 (20:49 -0500)
committerHypolite Petovan <hypolite@mrpetovan.com>
Sat, 7 Mar 2020 01:49:43 +0000 (20:49 -0500)
- Address https://github.com/friendica/friendica/issues/7998#issuecomment-594992869

src/Model/Item.php

index d47d19c..fe62e88 100644 (file)
@@ -3873,6 +3873,10 @@ class Item
                // first try to fetch the item via the GUID. This will work for all reshares that had been created on this system
                $shared_item = self::selectFirst(['title', 'body', 'attach'], ['guid' => $shared['guid'], 'uid' => [0, $uid]]);
                if (!DBA::isResult($shared_item)) {
+                       if (empty($shared['link'])) {
+                               return $item;
+                       }
+
                        // Otherwhise try to find (and possibly fetch) the item via the link. This should work for Diaspora and ActivityPub posts
                        $id = self::fetchByLink($shared['link'], $uid);
                        if (empty($id)) {