Function renamed
authorMichael <heluecht@pirati.ca>
Sun, 13 Sep 2020 19:40:38 +0000 (19:40 +0000)
committerMichael <heluecht@pirati.ca>
Sun, 13 Sep 2020 19:40:38 +0000 (19:40 +0000)
src/Protocol/DFRN.php
src/Util/XML.php

index 25adb5c..cc0042d 100644 (file)
@@ -1766,15 +1766,15 @@ class DFRN
 
                $msg = [];
                $msg["uid"] = $importer["importer_uid"];
-               $msg["from-name"] = XML::queryValue($xpath, "dfrn:sender/dfrn:name/text()", $mail);
-               $msg["from-url"] = XML::queryValue($xpath, "dfrn:sender/dfrn:uri/text()", $mail);
-               $msg["from-photo"] = XML::queryValue($xpath, "dfrn:sender/dfrn:avatar/text()", $mail);
+               $msg["from-name"] = XML::getFirstValue($xpath, "dfrn:sender/dfrn:name/text()", $mail);
+               $msg["from-url"] = XML::getFirstValue($xpath, "dfrn:sender/dfrn:uri/text()", $mail);
+               $msg["from-photo"] = XML::getFirstValue($xpath, "dfrn:sender/dfrn:avatar/text()", $mail);
                $msg["contact-id"] = $importer["id"];
-               $msg["uri"] = XML::queryValue($xpath, "dfrn:id/text()", $mail);
-               $msg["parent-uri"] = XML::queryValue($xpath, "dfrn:in-reply-to/text()", $mail);
-               $msg["created"] = DateTimeFormat::utc(XML::queryValue($xpath, "dfrn:sentdate/text()", $mail));
-               $msg["title"] = XML::queryValue($xpath, "dfrn:subject/text()", $mail);
-               $msg["body"] = XML::queryValue($xpath, "dfrn:content/text()", $mail);
+               $msg["uri"] = XML::getFirstValue($xpath, "dfrn:id/text()", $mail);
+               $msg["parent-uri"] = XML::getFirstValue($xpath, "dfrn:in-reply-to/text()", $mail);
+               $msg["created"] = DateTimeFormat::utc(XML::getFirstValue($xpath, "dfrn:sentdate/text()", $mail));
+               $msg["title"] = XML::getFirstValue($xpath, "dfrn:subject/text()", $mail);
+               $msg["body"] = XML::getFirstValue($xpath, "dfrn:content/text()", $mail);
 
                Mail::insert($msg);
        }
index ec4bbe1..039247c 100644 (file)
@@ -488,13 +488,19 @@ class XML
                return $first_item->attributes;
        }
 
-       public static function queryValue($xpath, $search, $context)
+       public static function getFirstValue($xpath, $search, $context)
        {
-               $result = $xpath->query($search, $context)->item(0)->nodeValue;
+               $result = $xpath->query($search, $context);
                if (!is_object($result)) {
                        return '';
                }
-               return $result->nodeValue;
+
+               $first_item = $result->item(0);
+               if (!is_object($first_item)) {
+                       return '';
+               }
+
+               return $first_item->nodeValue;
        }
 
        /**