Burn notices, burn
[friendica.git/.git] / include / enotify.php
index 257c107..70abce5 100644 (file)
@@ -8,7 +8,9 @@ use Friendica\Core\Addon;
 use Friendica\Core\Config;
 use Friendica\Core\L10n;
 use Friendica\Core\System;
-use Friendica\Database\DBM;
+use Friendica\Database\DBA;
+use Friendica\Model\Contact;
+use Friendica\Model\Item;
 use Friendica\Util\DateTimeFormat;
 use Friendica\Util\Emailer;
 
@@ -25,6 +27,25 @@ function notification($params)
 {
        $a = get_app();
 
+       // Temporary logging for finding the origin
+       if (!isset($params['language']) || !isset($params['uid'])) {
+               logger('Missing parameters.' . System::callstack());
+       }
+
+       // Ensure that the important fields are set at any time
+       $fields = ['notify-flags', 'language', 'username', 'email'];
+       $user = DBA::selectFirst('user', $fields, ['uid' => $params['uid']]);
+
+       if (!DBA::isResult($user)) {
+               logger('Unknown user ' . $params['uid']);
+               return;
+       }
+
+       $params['notify_flags'] = defaults($params, 'notify_flags', $user['notify-flags']);
+       $params['language'] = defaults($params, 'language', $user['language']);
+       $params['to_name'] = defaults($params, 'to_name', $user['username']);
+       $params['to_email'] = defaults($params, 'to_email', $user['email']);
+
        // from here on everything is in the recipients language
        L10n::pushLang($params['language']);
 
@@ -32,11 +53,11 @@ function notification($params)
        $product = FRIENDICA_PLATFORM;
        $siteurl = System::baseUrl(true);
        $thanks = L10n::t('Thank You,');
-       $sitename = $a->config['sitename'];
-       if (!x($a->config['admin_name'])) {
-               $site_admin = L10n::t('%s Administrator', $sitename);
+       $sitename = Config::get('config', 'sitename');
+       if (Config::get('config', 'admin_name')) {
+               $site_admin = L10n::t('%1$s, %2$s Administrator', Config::get('config', 'admin_name'), $sitename);
        } else {
-               $site_admin = L10n::t('%1$s, %2$s Administrator', $a->config['admin_name'], $sitename);
+               $site_admin = L10n::t('%s Administrator', $sitename);
        }
 
        $sender_name = $sitename;
@@ -48,15 +69,17 @@ function notification($params)
        $sender_email = $a->getSenderEmailAddress();
 
        if ($params['type'] != SYSTEM_EMAIL) {
-               $user = dba::selectFirst('user', ['nickname', 'page-flags'],
+               $user = DBA::selectFirst('user', ['nickname', 'page-flags'],
                        ['uid' => $params['uid']]);
 
                // There is no need to create notifications for forum accounts
-               if (!DBM::is_result($user) || in_array($user["page-flags"], [PAGE_COMMUNITY, PAGE_PRVGROUP])) {
+               if (!DBA::isResult($user) || in_array($user["page-flags"], [Contact::PAGE_COMMUNITY, Contact::PAGE_PRVGROUP])) {
                        return;
                }
+               $nickname = $user["nickname"];
+       } else {
+               $nickname = '';
        }
-       $nickname = $user["nickname"];
 
        // with $params['show_in_notification_page'] == false, the notification isn't inserted into
        // the database, and an email is sent if applicable.
@@ -91,7 +114,12 @@ function notification($params)
                $parent_id = 0;
        }
 
+       $epreamble = '';
+
        if ($params['type'] == NOTIFY_MAIL) {
+               $itemlink = $siteurl.'/message/'.$params['item']['id'];
+               $params["link"] = $itemlink;
+
                $subject = L10n::t('[Friendica:Notify] New mail received at %s', $sitename);
 
                $preamble = L10n::t('%1$s sent you a new private message at %2$s.', $params['source_name'], $sitename);
@@ -100,26 +128,20 @@ function notification($params)
                $sitelink = L10n::t('Please visit %s to view and/or reply to your private messages.');
                $tsitelink = sprintf($sitelink, $siteurl.'/message/'.$params['item']['id']);
                $hsitelink = sprintf($sitelink, '<a href="'.$siteurl.'/message/'.$params['item']['id'].'">'.$sitename.'</a>');
-               $itemlink = $siteurl.'/message/'.$params['item']['id'];
        }
 
        if ($params['type'] == NOTIFY_COMMENT) {
-               $thread = dba::selectFirst('thread', ['ignored'], ['iid' => $parent_id]);
-               if (DBM::is_result($thread) && $thread["ignored"]) {
+               $thread = Item::selectFirstThreadForUser($params['uid'] ,['ignored'], ['iid' => $parent_id]);
+               if (DBA::isResult($thread) && $thread["ignored"]) {
                        logger("Thread ".$parent_id." will be ignored", LOGGER_DEBUG);
                        return;
                }
 
                // Check to see if there was already a tag notify or comment notify for this post.
                // If so don't create a second notification
-               $p = q("SELECT `id` FROM `notify` WHERE `type` IN (%d, %d, %d) AND `link` = '%s' AND `uid` = %d LIMIT 1",
-                       intval(NOTIFY_TAGSELF),
-                       intval(NOTIFY_COMMENT),
-                       intval(NOTIFY_SHARE),
-                       dbesc($params['link']),
-                       intval($params['uid'])
-               );
-               if ($p && count($p)) {
+               $condition = ['type' => [NOTIFY_TAGSELF, NOTIFY_COMMENT, NOTIFY_SHARE],
+                       'link' => $params['link'], 'uid' => $params['uid']];
+               if (DBA::exists('notify', $condition)) {
                        L10n::popLang();
                        return;
                }
@@ -129,10 +151,11 @@ function notification($params)
                $item = null;
 
                if ($params['otype'] === 'item' && $parent_id) {
-                       $item = dba::selectFirst('item', [], ['id' => $parent_id]);
+                       $item = Item::selectFirstForUser($params['uid'], Item::ITEM_FIELDLIST, ['id' => $parent_id]);
                }
 
                $item_post_type = item_post_type($item);
+               $itemlink = $item['plink'];
 
                // "a post"
                $dest_str = L10n::t('%1$s commented on [url=%2$s]a %3$s[/url]',
@@ -152,7 +175,7 @@ function notification($params)
                }
 
                // "your post"
-               if (DBM::is_result($item) && $item['owner-id'] == $item['author-id'] && $item['wall']) {
+               if (DBA::isResult($item) && $item['owner-id'] == $item['author-id'] && $item['wall']) {
                        $dest_str = L10n::t('%1$s commented on [url=%2$s]your %3$s[/url]',
                                '[url='.$params['source_link'].']'.$params['source_name'].'[/url]',
                                $itemlink,
@@ -241,6 +264,7 @@ function notification($params)
        }
 
        if ($params['type'] == NOTIFY_TAGSHARE) {
+               $itemlink =  $params['link'];
                $subject = L10n::t('[Friendica:Notify] %s tagged your post', $params['source_name']);
 
                $preamble = L10n::t('%1$s tagged your post at %2$s', $params['source_name'], $sitename);
@@ -252,10 +276,10 @@ function notification($params)
                $sitelink = L10n::t('Please visit %s to view and/or reply to the conversation.');
                $tsitelink = sprintf($sitelink, $siteurl);
                $hsitelink = sprintf($sitelink, '<a href="'.$siteurl.'">'.$sitename.'</a>');
-               $itemlink =  $params['link'];
        }
 
        if ($params['type'] == NOTIFY_INTRO) {
+               $itemlink = $params['link'];
                $subject = L10n::t('[Friendica:Notify] Introduction received');
 
                $preamble = L10n::t('You\'ve received an introduction from \'%1$s\' at %2$s', $params['source_name'], $sitename);
@@ -269,7 +293,6 @@ function notification($params)
                $sitelink = L10n::t('Please visit %s to approve or reject the introduction.');
                $tsitelink = sprintf($sitelink, $siteurl);
                $hsitelink = sprintf($sitelink, '<a href="'.$siteurl.'">'.$sitename.'</a>');
-               $itemlink =  $params['link'];
 
                switch ($params['verb']) {
                        case ACTIVITY_FRIEND:
@@ -299,6 +322,7 @@ function notification($params)
        }
 
        if ($params['type'] == NOTIFY_SUGGEST) {
+               $itemlink =  $params['link'];
                $subject = L10n::t('[Friendica:Notify] Friend suggestion received');
 
                $preamble = L10n::t('You\'ve received a friend suggestion from \'%1$s\' at %2$s', $params['source_name'], $sitename);
@@ -315,11 +339,11 @@ function notification($params)
                $sitelink = L10n::t('Please visit %s to approve or reject the suggestion.');
                $tsitelink = sprintf($sitelink, $siteurl);
                $hsitelink = sprintf($sitelink, '<a href="'.$siteurl.'">'.$sitename.'</a>');
-               $itemlink =  $params['link'];
        }
 
        if ($params['type'] == NOTIFY_CONFIRM) {
                if ($params['verb'] == ACTIVITY_FRIEND) { // mutual connection
+                       $itemlink =  $params['link'];
                        $subject = L10n::t('[Friendica:Notify] Connection accepted');
 
                        $preamble = L10n::t('\'%1$s\' has accepted your connection request at %2$s', $params['source_name'], $sitename);
@@ -333,8 +357,8 @@ function notification($params)
                        $sitelink = L10n::t('Please visit %s if you wish to make any changes to this relationship.');
                        $tsitelink = sprintf($sitelink, $siteurl);
                        $hsitelink = sprintf($sitelink, '<a href="'.$siteurl.'">'.$sitename.'</a>');
-                       $itemlink =  $params['link'];
                } else { // ACTIVITY_FOLLOW
+                       $itemlink =  $params['link'];
                        $subject = L10n::t('[Friendica:Notify] Connection accepted');
 
                        $preamble = L10n::t('\'%1$s\' has accepted your connection request at %2$s', $params['source_name'], $sitename);
@@ -350,13 +374,13 @@ function notification($params)
                        $sitelink = L10n::t('Please visit %s  if you wish to make any changes to this relationship.');
                        $tsitelink = sprintf($sitelink, $siteurl);
                        $hsitelink = sprintf($sitelink, '<a href="'.$siteurl.'">'.$sitename.'</a>');
-                       $itemlink =  $params['link'];
                }
        }
 
        if ($params['type'] == NOTIFY_SYSTEM) {
                switch($params['event']) {
                        case "SYSTEM_REGISTER_REQUEST":
+                               $itemlink =  $params['link'];
                                $subject = L10n::t('[Friendica System Notify]') . ' ' . L10n::t('registration request');
 
                                $preamble = L10n::t('You\'ve received a registration request from \'%1$s\' at %2$s', $params['source_name'], $sitename);
@@ -365,7 +389,7 @@ function notification($params)
                                        '[url='.$params['source_link'].']'.$params['source_name'].'[/url]'
                                );
 
-                               $body = L10n::t('Full Name:     %1$s\nSite Location:    %2$s\nLogin Name:       %3$s ' . "\x28" . '%4$s' . "\x29",
+                               $body = L10n::t("Full Name:     %s\nSite Location:      %s\nLogin Name: %s (%s)",
                                        $params['source_name'],
                                        $siteurl, $params['source_mail'],
                                        $params['source_nick']
@@ -374,7 +398,6 @@ function notification($params)
                                $sitelink = L10n::t('Please visit %s to approve or reject the request.');
                                $tsitelink = sprintf($sitelink, $params['link']);
                                $hsitelink = sprintf($sitelink, '<a href="'.$params['link'].'">'.$sitename.'</a><br><br>');
-                               $itemlink =  $params['link'];
                                break;
                        case "SYSTEM_DB_UPDATE_FAIL":
                                break;
@@ -432,9 +455,7 @@ function notification($params)
                do {
                        $dups = false;
                        $hash = random_string();
-                       $r = q("SELECT `id` FROM `notify` WHERE `hash` = '%s' LIMIT 1",
-                               dbesc($hash));
-                       if (DBM::is_result($r)) {
+                       if (DBA::exists('notify', ['hash' => $hash])) {
                                $dups = true;
                        }
                } while ($dups == true);
@@ -464,45 +485,26 @@ function notification($params)
                }
 
                // create notification entry in DB
-               q("INSERT INTO `notify` (`hash`, `name`, `url`, `photo`, `date`, `uid`, `link`, `iid`, `parent`, `type`, `verb`, `otype`, `name_cache`)
-                       values('%s', '%s', '%s', '%s', '%s', %d, '%s', %d, %d, %d, '%s', '%s', '%s')",
-                       dbesc($datarray['hash']),
-                       dbesc($datarray['name']),
-                       dbesc($datarray['url']),
-                       dbesc($datarray['photo']),
-                       dbesc($datarray['date']),
-                       intval($datarray['uid']),
-                       dbesc($datarray['link']),
-                       intval($datarray['iid']),
-                       intval($datarray['parent']),
-                       intval($datarray['type']),
-                       dbesc($datarray['verb']),
-                       dbesc($datarray['otype']),
-                       dbesc($datarray["name_cache"])
-               );
+               $fields = ['hash' => $datarray['hash'], 'name' => $datarray['name'], 'url' => $datarray['url'],
+                       'photo' => $datarray['photo'], 'date' => $datarray['date'], 'uid' => $datarray['uid'],
+                       'link' => $datarray['link'], 'iid' => $datarray['iid'], 'parent' => $datarray['parent'],
+                       'type' => $datarray['type'], 'verb' => $datarray['verb'], 'otype' => $datarray['otype'],
+                       'name_cache' => $datarray["name_cache"]];
+               DBA::insert('notify', $fields);
 
-               $r = q("SELECT `id` FROM `notify` WHERE `hash` = '%s' AND `uid` = %d LIMIT 1",
-                       dbesc($hash),
-                       intval($params['uid'])
-               );
-               if ($r) {
-                       $notify_id = $r[0]['id'];
-               } else {
-                       L10n::popLang();
-                       return False;
-               }
+               $notify_id = DBA::lastInsertId();
 
                // we seem to have a lot of duplicate comment notifications due to race conditions, mostly from forums
                // After we've stored everything, look again to see if there are any duplicates and if so remove them
                $p = q("SELECT `id` FROM `notify` WHERE `type` IN (%d, %d) AND `link` = '%s' AND `uid` = %d ORDER BY `id`",
                        intval(NOTIFY_TAGSELF),
                        intval(NOTIFY_COMMENT),
-                       dbesc($params['link']),
+                       DBA::escape($params['link']),
                        intval($params['uid'])
                );
                if ($p && (count($p) > 1)) {
                        for ($d = 1; $d < count($p); $d ++) {
-                               dba::delete('notify', ['id' => $p[$d]['id']]);
+                               DBA::delete('notify', ['id' => $p[$d]['id']]);
                        }
 
                        // only continue on if we stored the first one
@@ -515,12 +517,10 @@ function notification($params)
                $itemlink = System::baseUrl().'/notify/view/'.$notify_id;
                $msg = replace_macros($epreamble, ['$itemlink' => $itemlink]);
                $msg_cache = format_notification_message($datarray['name_cache'], strip_tags(BBCode::convert($msg)));
-               q("UPDATE `notify` SET `msg` = '%s', `msg_cache` = '%s' WHERE `id` = %d AND `uid` = %d",
-                       dbesc($msg),
-                       dbesc($msg_cache),
-                       intval($notify_id),
-                       intval($params['uid'])
-               );
+
+               $fields = ['msg' => $msg, 'msg_cache' => $msg_cache];
+               $condition = ['id' => $notify_id, 'uid' => $params['uid']];
+               DBA::update('notify', $fields, $condition);
        }
 
        // send email notification if notification preferences permit
@@ -534,21 +534,12 @@ function notification($params)
                        $id_for_parent = $params['parent']."@".$hostname;
 
                        // Is this the first email notification for this parent item and user?
-
-                       $r = q("SELECT `id` FROM `notify-threads` WHERE `master-parent-item` = %d AND `receiver-uid` = %d LIMIT 1",
-                               intval($params['parent']),
-                               intval($params['uid']));
-
-                       // If so, create the record of it and use a message-id smtp header.
-
-                       if (!$r) {
+                       if (!DBA::exists('notify-threads', ['master-parent-item' => $params['parent'], 'receiver-uid' => $params['uid']])) {
                                logger("notify_id:".intval($notify_id).", parent: ".intval($params['parent'])."uid: ".intval($params['uid']), LOGGER_DEBUG);
-                               q("INSERT INTO `notify-threads` (`notify-id`, `master-parent-item`, `receiver-uid`, `parent-item`)
-                                       values(%d, %d, %d, %d)",
-                                       intval($notify_id),
-                                       intval($params['parent']),
-                                       intval($params['uid']),
-                                       0);
+
+                               $fields = ['notify-id' => $notify_id, 'master-parent-item' => $params['parent'],
+                                       'receiver-uid' => $params['uid'], 'parent-item' => 0];
+                               DBA::insert('notify-threads', $fields);
 
                                $additional_mail_header .= "Message-ID: <${id_for_parent}>\n";
                                $log_msg = "include/enotify: No previous notification found for this parent:\n".
@@ -557,15 +548,12 @@ function notification($params)
                        } else {
                                // If not, just "follow" the thread.
                                $additional_mail_header .= "References: <${id_for_parent}>\nIn-Reply-To: <${id_for_parent}>\n";
-                               logger("There's already a notification for this parent:\n".print_r($r, true), LOGGER_DEBUG);
+                               logger("There's already a notification for this parent.", LOGGER_DEBUG);
                        }
                }
 
-               // textversion keeps linebreaks
-               $textversion = strip_tags(str_replace("<br>", "\n", html_entity_decode(BBCode::convert(stripslashes(str_replace(["\\r\\n", "\\r", "\\n"], "\n",
-                       $body))),ENT_QUOTES, 'UTF-8')));
-               $htmlversion = html_entity_decode(BBCode::convert(stripslashes(str_replace(["\\r\\n", "\\r", "\\n\\n", "\\n"],
-                       "<br />\n", $body))), ENT_QUOTES, 'UTF-8');
+               $textversion = BBCode::toPlaintext($body);
+               $htmlversion = BBCode::convert($body);
 
                $datarray = [];
                $datarray['banner'] = $banner;
@@ -574,12 +562,12 @@ function notification($params)
                $datarray['sitename'] = $sitename;
                $datarray['siteurl'] = $siteurl;
                $datarray['type'] = $params['type'];
-               $datarray['parent'] = $params['parent'];
-               $datarray['source_name'] = $params['source_name'];
-               $datarray['source_link'] = $params['source_link'];
-               $datarray['source_photo'] = $params['source_photo'];
+               $datarray['parent'] = $parent_id;
+               $datarray['source_name'] = defaults($params, 'source_name', '');
+               $datarray['source_link'] = defaults($params, 'source_link', '');
+               $datarray['source_photo'] = defaults($params, 'source_photo', '');
                $datarray['uid'] = $params['uid'];
-               $datarray['username'] = $params['to_name'];
+               $datarray['username'] = defaults($params, 'to_name', '');
                $datarray['hsitelink'] = $hsitelink;
                $datarray['tsitelink'] = $tsitelink;
                $datarray['hitemlink'] = '<a href="'.$itemlink.'">'.$itemlink.'</a>';
@@ -609,7 +597,7 @@ function notification($params)
                        '$source_name'  => $datarray['source_name'],
                        '$source_link'  => $datarray['source_link'],
                        '$source_photo' => $datarray['source_photo'],
-                       '$username'     => $datarray['to_name'],
+                       '$username'     => $datarray['username'],
                        '$hsitelink'    => $datarray['hsitelink'],
                        '$hitemlink'    => $datarray['hitemlink'],
                        '$thanks'       => $datarray['thanks'],
@@ -630,7 +618,7 @@ function notification($params)
                        '$source_name'  => $datarray['source_name'],
                        '$source_link'  => $datarray['source_link'],
                        '$source_photo' => $datarray['source_photo'],
-                       '$username'     => $datarray['to_name'],
+                       '$username'     => $datarray['username'],
                        '$tsitelink'    => $datarray['tsitelink'],
                        '$titemlink'    => $datarray['titemlink'],
                        '$thanks'       => $datarray['thanks'],
@@ -665,13 +653,13 @@ function notification($params)
  */
 function check_user_notification($itemid) {
        // fetch all users in the thread
-       $users = dba::p("SELECT DISTINCT(`contact`.`uid`) FROM `item`
+       $users = DBA::p("SELECT DISTINCT(`contact`.`uid`) FROM `item`
                        INNER JOIN `contact` ON `contact`.`id` = `item`.`contact-id` AND `contact`.`uid` != 0
                        WHERE `parent` IN (SELECT `parent` FROM `item` WHERE `id`=?)", $itemid);
-       while ($user = dba::fetch($users)) {
+       while ($user = DBA::fetch($users)) {
                check_item_notification($itemid, $user['uid']);
        }
-       dba::close($users);
+       DBA::close($users);
 }
 
 /**
@@ -679,7 +667,7 @@ function check_user_notification($itemid) {
  *
  * @param int $itemid ID of the item for which the check should be done
  * @param int $uid User ID
- * @param str $defaulttype (Optional) Forces a notification with this type.
+ * @param string $defaulttype (Optional) Forces a notification with this type.
  */
 function check_item_notification($itemid, $uid, $defaulttype = "") {
        $notification_data = ["uid" => $uid, "profiles" => []];
@@ -687,14 +675,14 @@ function check_item_notification($itemid, $uid, $defaulttype = "") {
 
        $profiles = $notification_data["profiles"];
 
-       $fields = ['notify-flags', 'language', 'username', 'email', 'nickname'];
-       $user = dba::selectFirst('user', $fields, ['uid' => $uid]);
-       if (!DBM::is_result($user)) {
+       $fields = ['nickname'];
+       $user = DBA::selectFirst('user', $fields, ['uid' => $uid]);
+       if (!DBA::isResult($user)) {
                return false;
        }
 
-       $owner = dba::selectFirst('contact', ['url'], ['self' => true, 'uid' => $uid]);
-       if (!DBM::is_result($owner)) {
+       $owner = DBA::selectFirst('contact', ['url'], ['self' => true, 'uid' => $uid]);
+       if (!DBA::isResult($owner)) {
                return false;
        }
 
@@ -726,54 +714,50 @@ function check_item_notification($itemid, $uid, $defaulttype = "") {
 
        $profiles = $profiles2;
 
-       $profile_list = "";
+       $ret = DBA::select('contact', ['id'], ['uid' => 0, 'nurl' => $profiles]);
 
-       foreach ($profiles AS $profile) {
-               if ($profile_list != "")
-                       $profile_list .= "', '";
+       $contacts = [];
 
-               $profile_list .= dbesc($profile);
+       while ($contact = DBA::fetch($ret)) {
+               $contacts[] = $contact['id'];
        }
 
-       $profile_list = "'".$profile_list."'";
+       DBA::close($ret);
 
        // Only act if it is a "real" post
        // We need the additional check for the "local_profile" because of mixed situations on connector networks
-       $item = q("SELECT `id`, `mention`, `tag`,`parent`, `title`, `body`, `author-name`, `author-link`, `author-avatar`, `guid`,
-                       `parent-uri`, `uri`, `contact-id`
-                       FROM `item` WHERE `id` = %d AND `verb` IN ('%s', '') AND `type` != 'activity' AND
-                               NOT (`author-link` IN ($profile_list))  LIMIT 1",
-               intval($itemid), dbesc(ACTIVITY_POST));
-       if (!$item)
-               return false;
+       $fields = ['id', 'mention', 'tag', 'parent', 'title', 'body',
+               'author-link', 'author-name', 'author-avatar', 'author-id',
+               'guid', 'parent-uri', 'uri', 'contact-id', 'network'];
+       $condition = ['id' => $itemid, 'gravity' => [GRAVITY_PARENT, GRAVITY_COMMENT]];
+       $item = Item::selectFirst($fields, $condition);
+       if (!DBA::isResult($item) || in_array($item['author-id'], $contacts)) {
+               return;
+       }
 
        // Generate the notification array
        $params = [];
        $params["uid"] = $uid;
-       $params["notify_flags"] = $user["notify-flags"];
-       $params["language"] = $user["language"];
-       $params["to_name"] = $user["username"];
-       $params["to_email"] = $user["email"];
-       $params["item"] = $item[0];
-       $params["parent"] = $item[0]["parent"];
-       $params["link"] = System::baseUrl().'/display/'.urlencode($item[0]["guid"]);
+       $params["item"] = $item;
+       $params["parent"] = $item["parent"];
+       $params["link"] = System::baseUrl().'/display/'.urlencode($item["guid"]);
        $params["otype"] = 'item';
-       $params["source_name"] = $item[0]["author-name"];
-       $params["source_link"] = $item[0]["author-link"];
-       $params["source_photo"] = $item[0]["author-avatar"];
+       $params["source_name"] = $item["author-name"];
+       $params["source_link"] = $item["author-link"];
+       $params["source_photo"] = $item["author-avatar"];
 
-       if ($item[0]["parent-uri"] === $item[0]["uri"]) {
+       if ($item["parent-uri"] === $item["uri"]) {
                // Send a notification for every new post?
-               $send_notification = dba::exists('contact', ['id' => $item[0]['contact-id'], 'notify_new_posts' => true]);
+               $send_notification = DBA::exists('contact', ['id' => $item['contact-id'], 'notify_new_posts' => true]);
 
                if (!$send_notification) {
                        $tags = q("SELECT `url` FROM `term` WHERE `otype` = %d AND `oid` = %d AND `type` = %d AND `uid` = %d",
                                intval(TERM_OBJ_POST), intval($itemid), intval(TERM_MENTION), intval($uid));
 
-                       if (DBM::is_result($tags)) {
+                       if (DBA::isResult($tags)) {
                                foreach ($tags AS $tag) {
                                        $condition = ['nurl' => normalise_link($tag["url"]), 'uid' => $uid, 'notify_new_posts' => true];
-                                       $r = dba::exists('contact', $condition);
+                                       $r = DBA::exists('contact', $condition);
                                        if ($r) {
                                                $send_notification = true;
                                        }
@@ -791,29 +775,35 @@ function check_item_notification($itemid, $uid, $defaulttype = "") {
        $tagged = false;
 
        foreach ($profiles AS $profile) {
-               if (strpos($item[0]["tag"], "=".$profile."]") || strpos($item[0]["body"], "=".$profile."]"))
+               if (strpos($item["tag"], "=".$profile."]") || strpos($item["body"], "=".$profile."]"))
                        $tagged = true;
        }
 
-       if ($item[0]["mention"] || $tagged || ($defaulttype == NOTIFY_TAGSELF)) {
+       if ($item["mention"] || $tagged || ($defaulttype == NOTIFY_TAGSELF)) {
                $params["type"] = NOTIFY_TAGSELF;
                $params["verb"] = ACTIVITY_TAG;
        }
 
-       // Is it a post that the user had started or where he interacted?
-       $parent = q("SELECT `thread`.`iid` FROM `thread` INNER JOIN `item` ON `item`.`parent` = `thread`.`iid`
-                       WHERE `thread`.`iid` = %d AND NOT `thread`.`ignored` AND
-                               (`thread`.`mention` OR `item`.`author-link` IN ($profile_list))
-                       LIMIT 1",
-                       intval($item[0]["parent"]));
+       // Is it a post that the user had started?
+       $fields = ['ignored', 'mention'];
+       $thread = Item::selectFirstThreadForUser($params['uid'], $fields, ['iid' => $item["parent"]]);
 
-       if ($parent && !isset($params["type"])) {
+       if ($thread['mention'] && !$thread['ignored'] && !isset($params["type"])) {
                $params["type"] = NOTIFY_COMMENT;
                $params["verb"] = ACTIVITY_POST;
        }
 
-       if (isset($params["type"]))
+       // And now we check for participation of one of our contacts in the thread
+       $condition = ['parent' => $item["parent"], 'author-id' => $contacts];
+
+       if (!$thread['ignored'] && !isset($params["type"]) && Item::exists($condition)) {
+               $params["type"] = NOTIFY_COMMENT;
+               $params["verb"] = ACTIVITY_POST;
+       }
+
+       if (isset($params["type"])) {
                notification($params);
+       }
 }
 
 /**